x86emul: always fill x86_insn_modrm()'s outputs
authorJan Beulich <jbeulich@suse.com>
Wed, 19 Apr 2017 11:25:44 +0000 (13:25 +0200)
committerJan Beulich <jbeulich@suse.com>
Wed, 19 Apr 2017 11:25:44 +0000 (13:25 +0200)
commit818ff653a7afa51e11631e4ed373f70fd45e3a21
tree452fb2c979b0d9796ee988aa45d50d5ec299b890
parent75704266f987c11ed98cd0a26c52898ab358e95e
x86emul: always fill x86_insn_modrm()'s outputs

The function is rather unlikely to be called for insns which don't have
ModRM bytes, and hence addressing Coverity's recurring complaint of
callers potentially consuming uninitialized data when they know that
certain opcodes have ModRM bytes can be suppressed this way without
unduly adding overhead to fast paths.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Julien Grall <julien.grall@arm.com>
xen/arch/x86/x86_emulate/x86_emulate.c